Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd: rename setImageOptions() to constructImageOptions() #4833

Merged
merged 1 commit into from
Sep 12, 2024

Commits on Sep 12, 2024

  1. rbd: rename setImageOptions() to constructImageOptions()

    A function called `setImageOptions()` is expected to set the passed
    options on the volume. However, the passed options parameter is only
    filled with the options that should get set on the RBD-image at the time
    of creation.
    
    The naming of the function, and it's parameter is confusing. Rename the
    function to `constructImageOptions()` and return the ImageOptions to
    make it easier to understand.
    
    Signed-off-by: Niels de Vos <ndevos@ibm.com>
    nixpanic committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    a751b65 View commit details
    Browse the repository at this point in the history