Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rebase: bump ceph/ceph-csi from 28dc64dcae3cec8d11d84bdf525bda0ef757c688 to 29aecd345fd0de42da16a000e8d4e18ee0be18df #4862

Closed
wants to merge 1 commit into from
Closed

rebase: bump ceph/ceph-csi from 28dc64dcae3cec8d11d84bdf525bda0ef757c688 to 29aecd345fd0de42da16a000e8d4e18ee0be18df #4862

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/retest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
steps:
# path to the retest action
# yamllint disable-line rule:line-length
- uses: ceph/ceph-csi/actions/retest@28dc64dcae3cec8d11d84bdf525bda0ef757c688 # devel
- uses: ceph/ceph-csi/actions/retest@29aecd345fd0de42da16a000e8d4e18ee0be18df # devel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want this. Every time there is a change merged, it will get updated?

This should just point to the files in devel branch. @Nikhil-Ladha do you want to make that change and make sure that the security scanner doesn't complain about it in the future?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want this. Every time there is a change merged, it will get updated?

It will get updated at an interval of 1 week.

This should just point to the files in devel branch. @Nikhil-Ladha do you want to make that change and make sure that the security scanner doesn't complain about it in the future?

I am not sure if there is a way to bypass this for security scanner, there is an open feature plan for this with no update as of now: https://github.com/orgs/ossf/projects/24/views/1?pane=issue&itemId=55431256

with:
GITHUB_TOKEN: ${{ secrets.CEPH_CSI_BOT_TOKEN }}
required-label: "ci/retry/e2e"
Expand Down