Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPDK CPU auto detect code has issues #866

Closed
gbregman opened this issue Sep 12, 2024 · 0 comments · Fixed by #867
Closed

SPDK CPU auto detect code has issues #866

gbregman opened this issue Sep 12, 2024 · 0 comments · Fixed by #867
Assignees

Comments

@gbregman
Copy link
Contributor

gbregman commented Sep 12, 2024

We have come code in the gateway yo check if the user didn't supply a "--cpumask" or "-m" parameters to SPDK. In this is the case the gateway adds such a parameter using a bit mask based on the number of cores in the machine, but no more than 4. There is a problem with this code:

The code checks for "--cpumask" and "-m" in the SPDK command line list, but the actual values there are slightly different. For example, we might have there "--cpumask=0xF" which is not identical to "--cpumask". The result being that even if the user supplied a CPU mask in the configuration, the gateway still adds a second mask to the command line.

@gbregman gbregman self-assigned this Sep 12, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in NVMe-oF Sep 12, 2024
baum pushed a commit to baum/ceph-nvmeof that referenced this issue Sep 12, 2024
- ceph#866

Signed-off-by: Alexander Indenbaum <aindenba@redhat.com>
baum pushed a commit to baum/ceph-nvmeof that referenced this issue Sep 12, 2024
- ceph#866

Signed-off-by: Alexander Indenbaum <aindenba@redhat.com>
baum pushed a commit to baum/ceph-nvmeof that referenced this issue Sep 12, 2024
- ceph#866

Signed-off-by: Alexander Indenbaum <aindenba@redhat.com>
baum pushed a commit to baum/ceph-nvmeof that referenced this issue Sep 12, 2024
- ceph#866

Signed-off-by: Alexander Indenbaum <aindenba@redhat.com>
baum pushed a commit to baum/ceph-nvmeof that referenced this issue Sep 12, 2024
- ceph#866

Signed-off-by: Alexander Indenbaum <aindenba@redhat.com>
@gbregman gbregman linked a pull request Sep 12, 2024 that will close this issue
@gbregman gbregman assigned baum and unassigned gbregman Sep 12, 2024
baum pushed a commit that referenced this issue Sep 15, 2024
- #866

Signed-off-by: Alexander Indenbaum <aindenba@redhat.com>
@baum baum closed this as completed in #867 Sep 15, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NVMe-oF Sep 15, 2024
barakda pushed a commit that referenced this issue Sep 16, 2024
- #866

Signed-off-by: Alexander Indenbaum <aindenba@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants