Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/k8sevents: pin the kubernetes version to 11.0.0 #43668

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

nizamial09
Copy link
Member

@nizamial09 nizamial09 commented Oct 26, 2021

There's an API change (kubernetes-client/python@c04e2f6#diff-64d3d8da58fddca2ed360257976a6ab3e28fdc4805e3480d99af857ce914dc20R27-R32) happened during last night (morning depending on your timezone) which updated the V1Events to CoreV1Events. That causes a
make check failure and this commit intends to fix it.

kubernetes-client API Change PR: kubernetes-client/python#1597

Fixes: https://tracker.ceph.com/issues/53044
Signed-off-by: Nizamudeen A nia@redhat.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@nizamial09
Copy link
Member Author

nizamial09 commented Oct 26, 2021

The first run made the tests pass although some other tests failed. (https://jenkins.ceph.com/job/ceph-pull-requests/84498/console)

243/252 Test   #4: run-tox-mgr ...............................   Passed  288.51 sec

@nizamial09
Copy link
Member Author

@pcuzner @epuertat I am not entirely sure if this is correct approach. Some feedback would be nice. Also I am interested to know how we are using the kubernetes-client. Like do we get the latest version or do we pin a version? I'm assuming we are getting the latest one!

@alfonsomthd
Copy link
Contributor

@jmolmo @sebastian-philipp Can you take a look at this fix? See the original error.

@sebastian-philipp
Copy link
Contributor

we have to pin the version to the one shipped by our container image base (centos 8.?) Everything is not going to work.

@nizamial09
Copy link
Member Author

we have to pin the version to the one shipped by our container image base (centos 8.?) Everything is not going to work.

Yes, that should be the correct way rather than expecting these kinds of errors in every API change. I am not sure how to pin the version or which version we were using before. @sebastian-philipp

@nizamial09
Copy link
Member Author

Also i am not seeing the error happening on pacific, so it is using on older api.

@sebastian-philipp
Copy link
Contributor

@nizamial09
Copy link
Member Author

nizamial09 commented Oct 26, 2021

@sebastian-philipp I think we just need to pin the kubernetes version over here right? Probably to not the latest one? https://github.com/ceph/ceph/blob/pacific/src/pybind/mgr/requirements.txt#L3

https://pypi.org/project/kubernetes/#history

@sebastian-philipp
Copy link
Contributor

I'd pin it to 11.0.0 if that exist in pypi

@nizamial09
Copy link
Member Author

I'd pin it to 11.0.0 if that exist in pypi

It exists, and pinned it. Updated the PR.

@nizamial09 nizamial09 changed the title mgr/k8sevents: Update V1Events to CoreV1Events mgr/k8sevents: pin the kubernetes version to 11.0.0 Oct 26, 2021
@ljflores
Copy link
Contributor

Thank you @nizamial09!! I was looking into this last night and couldn't figure out the cause. This is very helpful.

@sebastian-philipp sebastian-philipp merged commit a9dd13a into ceph:master Oct 26, 2021
@nizamial09
Copy link
Member Author

You're welcome! @ljflores

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants