-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mgr/volumes: support to reject CephFS clones if cloner threads are not available #52670
Conversation
b96184f
to
b969f0a
Compare
@neesingh-rh I think this should be sent on top of #52765 ? |
Yup, I will do as soon as it merges or should I add those commits in this PR? |
Let's wait for it to merge. I think it's in @vshankar 's testing branch. |
I'll run PR #52765 through fs:volumes sub-suite to faster the merge process. |
jenkins retest this please |
3fa0299
to
43555ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vshankar I think this feature needs to be optional and enabled by default. It restricts other users to create a clone only when the thread is free. What do you think?
I think this feature needs to be enabled by the operator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me otherwise. Let's wait for the input whether we should make this configurable.
I was working on addition of this functionality ( taking Venky's suggestion #52670 (comment) in mind for now) and have updated the PR with those changes too, Will do the amendments as per the inputs. |
jenkins retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@neesingh-rh PTAL at the failure: /a/vshankar-2024-01-22_07:03:31-fs-wip-vshankar-testing-20240119.075157-1-testing-default-smithi/7525715
* refs/pull/52670/head: doc: add the reject the clone when threads are not available feature in the doc qa: add test cases for the support to reject clones feature mgr/volumes: support to reject CephFS clones if cloner threads are not available Reviewed-by: Venky Shankar <vshankar@redhat.com> Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
…t available CephFS clone creation have a limit of 4 parallel clones by default at a time and rest of the clone create requests are queued. This makes CephFS cloning very slow when there is large amount of clones being created.After this patch clone requests won't be accepeted when the requests exceed the `max_concurrent_clones` config value. Fixes: https://tracker.ceph.com/issues/59714 Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
7995354
to
7c2c206
Compare
7c2c206
to
353db29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wording requests
Fixes: https://tracker.ceph.com/issues/59714 Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
…in the document Fixes: https://tracker.ceph.com/issues/59714 Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
178b6c9
to
6a44322
Compare
* refs/pull/52670/head: doc: add the reject the clone when threads are not available feature in the document qa: add test cases for the support to reject clones feature mgr/volumes: support to reject CephFS clones if cloner threads are not available Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com> Reviewed-by: Venky Shankar <vshankar@redhat.com>
jenkins test windows |
@neesingh-rh I had to include an additional commit to gixup failures in the fs:volumes. No need to refresh - I'll merge this and the additional commit tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Allow the cloning only when (pending_clones + in-progress_clones) < max_concurrent_clones, otherwise return the error EAGAIN. This way we solves the issue of stale cephfs clones.
Fixes: https://tracker.ceph.com/issues/59714
Signed-off-by: Neeraj Pratap Singh neesingh@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows