-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cephfs admin: remove test skip in TestCancelClone #684
Conversation
Interesting: first run in the CI it reproduced the error. See #679 for updated details. |
e5feb11
to
17bfdba
Compare
This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏 |
2114b9f
to
da327e9
Compare
This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏 |
6408c97
to
c998859
Compare
df88425
to
4675755
Compare
@Mergifyio rebase |
✅ Branch has been successfully rebased |
c839197
to
b91e184
Compare
O M G.... It's actually passing!? I guess it's time to clean it up and actually propose this. |
b91e184
to
1f8e522
Compare
I think commit message should mention that it re-enables the test case on both pacific and quincy.
|
1f8e522
to
2a593d1
Compare
Done |
@Mergifyio rebase |
This will re-enable the test case on ceph quincy and pacific. Signed-off-by: John Mulligan <jmulligan@redhat.com>
There was continued flakiness when the tests that enabled the cephfs mirroring module were enabled. This change adds another 200 ms delay to hopefully cover the time that might occur as the mgr has a new module enabled and restart. But unfortunately this is still a bit of a wild guess. Signed-off-by: John Mulligan <jmulligan@redhat.com>
✅ Branch has been successfully rebased |
2a593d1
to
cc97ee9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This will re-enable the test case on ceph quincy.
The test does not seem to be reproducing the error on my local machine with the latest quincy image. Making a PR to see if its more related to my system and can still reproduce on the CI or not.
Checklist