Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apiage: Remove empty tables from API status markdown #775

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

anoopcs9
Copy link
Collaborator

There are instances in API status json with empty list for preview or deprecated APIs. Due to a missing empty check we had corresponding tables created in markdown without any content. While adding the empty check also modify the condition which adds an entry indicating absence of any preview/deprecated APIs to consider empty lists.

There are instances in API status json with empty list for preview or
deprecated APIs. Due to a missing empty check we had corresponding
tables created without any content.

While adding the empty check also modify the condition which adds an
entry indicating absence of any preview/deprecated APIs to consider
empty lists.

Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
Copy link
Collaborator

@ansiwen ansiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anoopcs9 anoopcs9 added the no-API This PR does not include any changes to the public API of a go-ceph package label Oct 18, 2022
@mergify mergify bot merged commit 1fe5774 into ceph:master Oct 18, 2022
@anoopcs9 anoopcs9 deleted the fix-api-status-md branch October 18, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-API This PR does not include any changes to the public API of a go-ceph package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants