Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cephfs/admin: Add API to fetch volume info #846

Merged
merged 3 commits into from
Mar 20, 2023
Merged

cephfs/admin: Add API to fetch volume info #846

merged 3 commits into from
Mar 20, 2023

Conversation

anoopcs9
Copy link
Collaborator

@anoopcs9 anoopcs9 commented Mar 15, 2023 •
edited
Loading

Checklist

  • Added tests for features and functional changes
  • Public functions and types are documented
  • Standard formatting is applied to Go code
  • Is this a new API? Added a new file that begins with //go:build ceph_preview
  • Ran make api-update to record new APIs

Fixes #695

@anoopcs9 anoopcs9 force-pushed the fetch-volume-info branch 2 times, most recently from fe07036 to 487a8b2 Compare March 15, 2023 09:21
@anoopcs9 anoopcs9 marked this pull request as ready for review March 15, 2023 09:49
@anoopcs9 anoopcs9 changed the title cepfs/admin: Add API to fetch volume info cephfs/admin: Add API to fetch volume info Mar 15, 2023
@anoopcs9 anoopcs9 added the API This PR includes a change to the public API of a go-ceph package label Mar 15, 2023
@phlogistonjohn
Copy link
Collaborator

It would be good to add a line to the desciption for dpulls to key off of since this is based on the work in 844. I think Depends on: #844 is sufficient.

@dpulls
Copy link

dpulls bot commented Mar 17, 2023

🎉 All dependencies have been resolved !

@mergify
Copy link

mergify bot commented Mar 17, 2023

This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏

@anoopcs9
Copy link
Collaborator Author

@Mergifyio rebase

@anoopcs9
cephfs/admin: Add API to fetch volume info
72cc4a7 
Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
@anoopcs9
cephfs/admin: Add tests for API fetching volume info
6f1dab1 
Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
@anoopcs9
docs: Add volume info fetching API to api-status
cac917d 
Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
@mergify
Copy link

mergify bot commented Mar 20, 2023

rebase

✅ Branch has been successfully rebased

phlogistonjohn
phlogistonjohn approved these changes Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. In and ideal world I would also have a few unit tests that exercise just the parseVolumeInfo function, but since the structs in question are pretty simple I won't require it.

ansiwen
ansiwen approved these changes Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@ansiwen ansiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 48afd41 into ceph:master Mar 20, 2023
@anoopcs9 anoopcs9 deleted the fetch-volume-info branch March 20, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansiwen ansiwen ansiwen approved these changes

@phlogistonjohn phlogistonjohn phlogistonjohn approved these changes

Assignees
No one assigned
Labels
API This PR includes a change to the public API of a go-ceph package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cephfs: Add wrapper to consume 'ceph fs volume info' command.
3 participants
@anoopcs9 @phlogistonjohn @ansiwen