Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw/admin: Add missing uid member to usage struct #848

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

Nikhil-Ladha
Copy link
Contributor

@Nikhil-Ladha Nikhil-Ladha commented Mar 16, 2023

Description

Added the uid member to the usage type.
We don't need to handle the uid here, as the ceph function handles it in the backend.

Fixes: #758

Signed-off-by: Nikhil-Ladha nikhilladha1999@gmail.com

Checklist

  • Added tests for features and functional changes
  • Public functions and types are documented
  • Standard formatting is applied to Go code
  • Is this a new API? Added a new file that begins with //go:build ceph_preview
  • Ran make api-update to record new APIs

@Nikhil-Ladha
Copy link
Contributor Author

@thotz can you PTAL?
TIA :)

@Nikhil-Ladha
Copy link
Contributor Author

Thanks for the review @thotz . Are we good to merge the PR in that case?

Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@anoopcs9
Copy link
Collaborator

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Mar 18, 2023

rebase

❌ Unable to rebase: user anoopcs9 is unknown.

Please make sure anoopcs9 has logged in Mergify dashboard.

@anoopcs9
Copy link
Collaborator

rebase

x Unable to rebase: user anoopcs9 is unknown.

Ok. I'll try once again.

@anoopcs9
Copy link
Collaborator

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Mar 18, 2023

rebase

❌ Unable to rebase: user anoopcs9 is unknown.

Please make sure anoopcs9 has logged in Mergify dashboard.

@anoopcs9
Copy link
Collaborator

rebase

x Unable to rebase: user anoopcs9 is unknown.

Please make sure anoopcs9 has logged in Mergify dashboard.

Authorized..let's see now.

@anoopcs9
Copy link
Collaborator

@Mergifyio rebase

**Description:**
Added the uid member to the usage type.
We don't need to handle the uid here, as the ceph funtion handles it in the backend.

Fixes: ceph#758

Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
@mergify
Copy link

mergify bot commented Mar 18, 2023

rebase

✅ Branch has been successfully rebased

@anoopcs9 anoopcs9 added the bug label Mar 20, 2023
@anoopcs9 anoopcs9 added bug no-API This PR does not include any changes to the public API of a go-ceph package and removed bug labels Mar 20, 2023
@mergify mergify bot merged commit 9640809 into ceph:master Mar 20, 2023
@Nikhil-Ladha Nikhil-Ladha deleted the issue758/fix-struct branch March 20, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug no-API This PR does not include any changes to the public API of a go-ceph package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uid is missing from usage type in GetUsage method
3 participants