Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RunList: use Custom filter #84

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

RunList: use Custom filter #84

wants to merge 6 commits into from

Commits on Nov 14, 2024

  1. RunList: Use custom filter

    - Use custom filter to show filter inputs
      outside the table
    - Add a button to expand/hide filter options
    - Display sort button only on hover over the column title
    - Disable column action buttons (all of it's functions
      can be performed with sort, filter, and show/hide column
      buttons)
    
    Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
    VallariAg committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    6729b27 View commit details
    Browse the repository at this point in the history
  2. RunList: Show filters in 3 sections

    Show the RunList custom filter in 3 sections:
    build details, run details, result details.
    
    This commit also does the following:
    1. Hides the default filter icon from table
    2. Hides filter icon present in filtered columns
    
    Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
    VallariAg committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    a129931 View commit details
    Browse the repository at this point in the history
  3. RunList: show Badge for number of filters applied

    Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
    VallariAg committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    2d48b82 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. RunList: Make FilterMenu as a popover menu

    Make FilterMenu more compact and turn it into
    a pop-over menu instead of having it open above the table.
    
    Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
    VallariAg committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    250b597 View commit details
    Browse the repository at this point in the history
  2. RunList: Put filter button inside the table menu

    - use renderTopToolbarCustomActions to add the
      filter button inside the table menu
    - Show what filters are applied at top right of
      the table.
    
    Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
    VallariAg committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    a0cc198 View commit details
    Browse the repository at this point in the history
  3. src/lib/paddles.ts: allow machine_type filter for useRuns

    This is to handle difference in machine_type filter in
    two endpoints /node/?machine_type=xyz and /runs/machine_type/xyz
    
    Fixes machine_type filter for RunList.
    
    Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
    VallariAg committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    9d6cacc View commit details
    Browse the repository at this point in the history