Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

./github/workflows/signed.yaml: Create CI for checking signed commits #11

Merged
merged 1 commit into from
Aug 7, 2023
Merged

./github/workflows/signed.yaml: Create CI for checking signed commits #11

merged 1 commit into from
Aug 7, 2023

Conversation

Devansh3712
Copy link
Member

This PR fixes #6 using a bash script that checks for Signed-off-by: trailer in git commits. The script does not check the merge commits as they generally don't have the Signed-off-by: trailer.

Signed-off-by: Devansh3712 <devanshamity@gmail.com>
@kamoltat
Copy link
Member

kamoltat commented Aug 2, 2023

Hmm The CI said the commit is not signed although I can see pretty clearly that you signed ... I wonder if there is actually something wrong or is it some sort of glitch in github.

@kamoltat kamoltat added the CI CI/CD related stuff label Aug 2, 2023
Copy link
Member

@kamoltat kamoltat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets see if it is actually a glitch in github

@kamoltat kamoltat merged commit 170d4bb into ceph:main Aug 7, 2023
2 of 3 checks passed
kamoltat added a commit that referenced this pull request Aug 23, 2023
@kamoltat kamoltat mentioned this pull request Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI/CD related stuff
Projects
Development

Successfully merging this pull request may close these issues.

Actions: check for signed commit
2 participants