Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

services/kill.py: Allow admins to kill any run #55

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

services/kill.py: Allow admins to kill any run #55

wants to merge 9 commits into from

Conversation

VallariAg
Copy link
Member

@VallariAg VallariAg commented Apr 24, 2024 •
edited
Loading

Admins are users who are on "Ceph" team on github.
This PR also improves error handling for kill route.

Contribution Guidelines

To sign and test your commits, please refer to Contibution guidelines.

Checklist

@VallariAg VallariAg mentioned this pull request Apr 24, 2024
Open
@VallariAg VallariAg self-assigned this Jun 13, 2024
@VallariAg VallariAg added the enhancement Improving existing feature or logic label Jun 13, 2024
@VallariAg
services/kill.py: Allow admins to kill any run
9e951c8 
Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
@VallariAg
services/kill.py: Owner can also be "scheduled_<username>@teuthology"
28af01a 
"scheduled_<username>@teuthology" is the default owner name if
run is scheduled from teuthology CLI tool. This commit allows
users of same github username to recognize it as their jobs.

Also fix how run_owner is determined. In teuthology, runs ownership
is deteremined by job's "owner" and not run's "user" value.

Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
@VallariAg
login: add 'isUserAdmin' to session data
86d386c 
Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
kamoltat
kamoltat requested changes Jul 17, 2024
View reviewed changes
Copy link
Member

@kamoltat kamoltat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor coding style comments and env variable stuff, other than that, everything else looks fine

src/teuthology_api/services/helpers.py Outdated Show resolved Hide resolved
src/teuthology_api/services/helpers.py Outdated Show resolved Hide resolved
src/teuthology_api/services/kill.py Show resolved Hide resolved
@VallariAg
kill: add tests + fix run owner logic
ec62bf9 
Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
@VallariAg
Improve error handling
f246efa 
And decode kill-cmd output logs.

Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
@VallariAg
services/kill.py: optionally add boolean value flag in kill cmd
779b632 
For example, value of "--preserve-queues" is boolean in /kill request
schema. If it's true, add it to the kill cmd, otherwise don't add the
flag.

Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
@VallariAg
services/helpers.py: handle empty GH_ORG_TEAM_URL and ADMIN_TEAM
6c4b5f4 
Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
@zmc zmc requested a review from kamoltat August 28, 2024 22:29
@VallariAg
main.py: add CORSMiddleware for non-dev env
2043d97 
Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
@VallariAg
Send user avatar in session data
5e4d1e4 
Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamoltat kamoltat Awaiting requested review from kamoltat

Requested changes must be addressed to merge this pull request.

Assignees

@VallariAg VallariAg

Labels
enhancement Improving existing feature or logic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VallariAg @kamoltat