Disabled github auth for dev setup and set up default as development #66 #69
Conversation
|
@VallariAg can you kindly check the task and merge the pull request. |
There was a problem hiding this comment.
Hello @AyishikD, thanks for opening this PR. I've left a few comments.
Additionally, please merge the three commits into one. Also here are the instructions to sign commits: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits
AyishikD
force-pushed
the
main
branch
2 times, most recently
from
558bf92
to
00c2c25
Compare
|
@VallariAg kindly check now and regarding the random line changes I pasted the original code from github to remove them but they are still there. Rest changes I have done. |
|
@VallariAg can you kindly recheck and notify me if any changes are needed else merge the changes. Thank you in advance. |
|
@VallariAg I completely deleted my commit and added only the required lines still random new lines with @@ are coming . I tried git diff too the more I change the more it increases or remains. I think the new line additions in the middle may have caused it since line numbers are increased. Sorry to say I cannot fix the random new lines cause the more I try more complex they become. |
|
@VallariAg I checked in diffchecker too even the software told me no extra blank lines or less blank lines are present in between the two files except my changed lines. |
There was a problem hiding this comment.
@AyishikD I think you've done a great job removing the random new lines - I only see a couple of them now!
You can try out VS Code: https://code.visualstudio.com/docs/sourcecontrol/overview#_viewing-diffs
It has amazing view of looking at diffs which would help you to only keep the intentional-made changes before making a commit.
I see that your commit message now includes title of all the commits you merged (bunch of repeated lines of sign-offs and "removed github...").
You can change the commit message to be more neat (example: 3798208).
To edit your commit message, you can look up about git commit --amend command.
AyishikD
force-pushed
the
main
branch
2 times, most recently
from
d471604
to
60f2368
Compare
|
@VallariAg I have added the extra line gaps through vs code source control where they were previously. I don't think any line blanks are less or more now. Also, I have amended the commit message as you gave in the example. Thank you. |
|
Hii @VallariAg did u check the latest commit? |
|
Hi @VallariAg its been 2 days since I pushed the last commit. Please can you kindly check it? |
There was a problem hiding this comment.
Nice work, it's looking more neater now. I've left a couple more comments. The commit seems to have 1 extra commit title and sign-off, we can probably remove that too.
Also we can revisit the commit description. Example, "- suite.py route: Removed GitHub auth requirement during development." - this is no longer true because we removed this check from routes/suite.py from last iteration of review.
More importantly...
I haven't tested the PR locally yet (and I'll probably only have time to do it later in week). You can test it by sending a request to /suite endpoint to ensure it works after this change. This can be done by using FastAPI Swagger UI (found at /docs endpoint on a browser) and sample payload in README. Please understand that reviews might sometimes take a couple days, especially if there's a weekend. Thanks!
Signed-off-by: AyishikD <99983449+AyishikD@users.noreply.github.com> Disabled GitHub authentication for the development setup. This change affects the following files: - `main.py`: Modified to skip the `access_token` check during development. - `services`: Updated logic to bypass auth checks when in development mode.
|
@VallariAg I did the changes u mentioned. Tried testing locally where it gave error "ERROR: Could not find a version that satisfies the requirement ansible-core==2.16.6 (from teuthology)" Some kind of json error I guess |
|
@AyishikD I recommend you to try the docker setup to test /suite (it's the easier method) - the instructions are in README. About the invalid JSON, if you're using the sample payload from README, make sure you have removed the comment starting with |
While setting up in docker
|
|
@AyishikD I have never seen that error before, can you share the steps you took to reach here? |
Yeah suree |
|
@AyishikD It would be more helpful to share commands you ran and their outputs - it's hard to reproduce a problem with vague instructions. But looking at the error you shared before, I think the problem could be that you're supposed to run "./start.sh" in See if you're following these steps: https://github.com/ceph/teuthology-api/blob/main/gh-actions/start.sh |
Yeah as per instruction I executed the start.sh file
|
|
@AyishikD it seems to me that you have taken a misstep when setting up the two repos. I think you might be running the command from a wrong directory which is why the "bootstrap" is missing. Can you confirm this is what you did? If it's still not working, share the exact commands you ran and where you ran them and the output, example: |
My docker-compose file in teuthology is like this: |
|
@AyishikD Everything looks correct to me, that's great. I see there's some cached layers, can you try https://docs.docker.com/reference/cli/docker/system/prune/ and then rerun start.sh and see if that works? |
failed to solve: process "/bin/sh -c cd /teuthology && mkdir ../archive_dir && mkdir log && chmod +x /teuthology/bootstrap && PIP_INSTALL_FLAGS="-r requirements.txt" ./bootstrap" did not complete successfully: exit code: 127 same error is coming after running |
|
|
Hey @VallariAg did you see the latest problem? |
|
Can you try to clean up all changes from docker-compose and run start.sh again? |
|
I cleaned the docker.compose file and returned it to the original state and ran But still the same error is coming |
|
Hmm seems weird. Can you see if there are any other changes on your local teuthology repo? @kamoltat do you know what could be the issue here? |
In the teuthology repo I had only changed the docker.compose file after which I had again resetted it but still the same error came. |
|
@VallariAg any update mam? |
|
@AyishikD I still don't understand the cause of the problem. If you're available, you can join "Teuthology weekly" call today at 8pm IST using this link https://meet.jit.si/ceph-teuthology. |
Sure mam I am joining today only in meet. |
|
@VallariAg fixed postgresql error by using the commands and in the 01-init.sh changed to But now error is coming as unhealthy :( |
|
@VallariAg At ubuntu distro in wsl same error on running ./start.sh Bootstrap error.. |
|
Hii @VallariAg sorry for disturbing , did u check it? |
|
Sorry I was on vacation, happy diwali @AyishikD :) |
@VallariAg my Ubuntu version is 22.04.05 LTS. Also, the code that sir told me in the meeting is running and creating a container, but the code which is actually here in teuthology does not work and gives an error. Thank you mam for your so much guidance. |
Disabled github auth for dev setup and set up default as development
Fixes #66
Changed and removed github auth for development in suite.py route, main.py and the services part.
The access_token check is skipped during dev setup.
By default deployment is set to development if not explicitly mentioned
Checklist