chore: update ipfs (now with typing) dependencies #1337

achingbrain · 2021-04-30T09:45:42Z

This follows on from #1194 with a few extra bits and pieces (can target that branch for merging if it's preferable):

Updates types
Removes multiformats in favour of blockcodec-to-ipld-format as it outputs the correct types
Swaps ipfs for ipfs-core - no need to pull down cli deps etc if they're not being used
Updates ipld-dag-cbor to the latest version
Depends on next for ipfs-* to get the latest rc

…-w-types

oed · 2021-04-30T10:22:08Z

Thanks @achingbrain looking forward to having native ipfs typings!

Will let others review this PR in depth.

Depends on next for ipfs-* to get the latest rc

I assume this PR is a draft until new IPFS versions are release? :)

achingbrain · 2021-04-30T10:24:01Z

Yes! Sorry, I should have opened it as a draft..

achingbrain · 2021-04-30T10:33:33Z

The following commands in this repo now work for me:

$ npm install
$ npm run build
$ npm test

Please let me know if there's anything else I should be running..

oed · 2021-04-30T10:35:01Z

What node version are you on @achingbrain ?

What errors are you seeing when running npm install?

achingbrain · 2021-04-30T10:37:25Z

What node version are you on @achingbrain ?

I tried 15 but saw errors related to peer dependencies caused by the change in how npm@7 handles them.

What errors are you seeing when running npm install?

None, like I said, the commands above work without error 😄

oed · 2021-04-30T10:39:27Z

Oh, haha!

I misread 😹

oed · 2021-04-30T10:39:56Z

You should also run npm run lint.

achingbrain · 2021-04-30T12:39:19Z

There's one @ts-ignore that needs removing, just needs ipfs/js-ipfs#3660 landing.

achingbrain · 2021-05-02T07:21:53Z

That's been merged & released as an rc, linting is happy now.

stbrody

A few very minor comments but overall this looks really great. I'm excited to get this merged in.

I'd still like @ukstv to take a look as well to double-check me, especially around the serialization/deserialization stuff in pubsub.

packages/common/src/index.ts

packages/core/src/__tests__/ipfs-util.ts

packages/core/src/pubsub/pubsub.ts

packages/ipfs-daemon/src/ipfs-daemon.ts

achingbrain · 2021-05-04T15:28:21Z

@stbrody I think I've removed all the outstanding ts-ignores now, as well as the double-serialization of the pubsub message.

I'm going to flesh out the test suite for blockcodec-to-ipld-format and publish a v1 but other than that please feel free to point out any bits of the API that look odd to you or other points of friction.

…-w-types

achingbrain · 2021-05-12T11:21:07Z

Everything's been released so this should be good to go, pending anything further review uncovers.

…w-types

oed

lgtm :)

oed · 2021-06-02T08:50:33Z

packages/common/src/index.ts

+import type { IPFS } from 'ipfs-core-types'
+export type IpfsApi = IPFS


This is nice. We should probably just start importing this type everywhere in the furtue, rather than reexporting it :)

oed · 2021-06-02T10:09:29Z

packages/ipfs-daemon/src/ipfs-daemon.ts

@@ -148,9 +142,8 @@ export class IpfsDaemon {
                    ...configuration.ipfsEnableApi && {API: `/ip4/${configuration.tcpHost}/tcp/${configuration.ipfsApiPort}`},
                    ...configuration.ipfsEnableGateway && {Gateway: `/ip4/${configuration.tcpHost}/tcp/${configuration.ipfsGatewayPort}`}
                    ,
+                    Announce: configuration.announceAddressList,


Why is this passed to both config and libp2p.config?

I was actually wondering the same thing, it shouldn't be necessary to pass the list in both places.

oed · 2021-06-02T10:12:08Z

We should make sure that all of these work:

$ npm install
$ npm run build
$ npm test
$ npm run lint
$ npm run docs

stbrody · 2021-06-02T17:37:13Z

packages/ipfs-topology/src/ipfs-topology.ts

  ): Promise<void> {
    // Don't want to swarm connect to ourself
    const myPeerId = (await ipfs.id()).id
    const filteredBootstrapList = bootstrapList.filter((addr) => {
-      return !addr.endsWith(myPeerId)
+      return !addr.getPeerId()?.endsWith(myPeerId)


@achingbrain, I pulled down this PR and updated all the ipfs deps in the various package.json files to use next. The tests all passed, but running ceramic daemon in a terminal causes this line to throw the error:

Connecting to peers found in 'https://raw.githubusercontent.com/ceramicnetwork/peerlist/main/testnet-clay.json' (node:126315) UnhandledPromiseRejectionWarning: TypeError: addr.getPeerId is not a function at /home/spencer/js-ceramic4/packages/ipfs-topology/lib/ipfs-topology.js:105:33 at Array.filter (<anonymous>) at IpfsTopology._forceBootstrapConnection (/home/spencer/js-ceramic4/packages/ipfs-topology/lib/ipfs-topology.js:103:53) at processTicksAndRejections (internal/process/task_queues.js:93:5) at async IpfsTopology.forceConnection (/home/spencer/js-ceramic4/packages/ipfs-topology/lib/ipfs-topology.js:78:9) at async IpfsTopology.start (/home/spencer/js-ceramic4/packages/ipfs-topology/lib/ipfs-topology.js:81:9) at async Ceramic._init (/home/spencer/js-ceramic4/packages/core/lib/ceramic.js:257:13) at async Function.create (/home/spencer/js-ceramic4/packages/cli/lib/ceramic-daemon.js:124:9) at async Command.<anonymous> (/home/spencer/js-ceramic4/packages/cli/lib/bin/ceramic.js:34:5)

The multiaddress in the file from there are in string and needs to be converted into a Multiaddress instance.

Yep that was it. Pushed a fix to this PR branch, seems to be working now. I was able to run a node on the clay testnet, create and update a stream, and then load that stream from the clay gateway

This reverts commit 2b87257.

packages/ipfs-topology/src/ipfs-topology.ts

stbrody · 2021-06-02T17:55:47Z

We should make sure that all of these work:
$ npm install
$ npm run build
$ npm test
$ npm run lint
$ npm run docs

Done. All working

rvagg and others added 5 commits April 26, 2021 19:37

chore: update ipfs (now with typing) dependencies

42491b7

fixup! chore: update ipfs (now with typing) dependencies

4a7476b

chore: refactor for new types

cfc4640

Merge remote-tracking branch 'upstream/develop' into achingbrain/ipfs…

8041626

…-w-types

chore: update lock return types

e06a4e8

oed requested review from ukstv and stbrody April 30, 2021 10:22

oed assigned stbrody Apr 30, 2021

achingbrain marked this pull request as draft April 30, 2021 10:23

chore: fix up tests and test types

f194d69

chore: remove ts-ignore to fix linting

112c299

stbrody reviewed May 3, 2021

View reviewed changes

packages/common/src/index.ts Outdated Show resolved Hide resolved

packages/core/src/__tests__/ipfs-util.ts Outdated Show resolved Hide resolved

packages/core/src/pubsub/pubsub.ts Outdated Show resolved Hide resolved

packages/ipfs-daemon/src/ipfs-daemon.ts Outdated Show resolved Hide resolved

rvagg mentioned this pull request May 4, 2021

js-ipfs dependency updates, now with full types (WIP) #1194

Closed

chore: remove all ipfs related ts-ignores

6e359fe

achingbrain added 2 commits May 6, 2021 12:46

chore: update blockcodec-to-ipld-format to v1

187db22

chore: replace next with release versions

73113dc

achingbrain marked this pull request as ready for review May 12, 2021 11:15

Merge remote-tracking branch 'upstream/develop' into achingbrain/ipfs…

b3140f8

…-w-types

stbrody mentioned this pull request May 31, 2021

Update to blockcodec-to-ipld-format ceramicnetwork/docs#56

Closed

Merge remote-tracking branch 'upstream/master' into achingbrain/ipfs-…

9f360ce

…w-types

oed approved these changes Jun 2, 2021

View reviewed changes

stbrody reviewed Jun 2, 2021

View reviewed changes

Spencer T Brody added 3 commits June 2, 2021 13:46

Return peerlist nodes as Multiaddr instances

c0f4c6c

update ipfs packages to 'next'

2b87257

Revert "update ipfs packages to 'next'"

964a978

This reverts commit 2b87257.

stbrody reviewed Jun 2, 2021

View reviewed changes

packages/ipfs-topology/src/ipfs-topology.ts Outdated Show resolved Hide resolved

stbrody reviewed Jun 2, 2021

View reviewed changes

packages/ipfs-topology/src/ipfs-topology.ts Outdated Show resolved Hide resolved

Handle null list

7310aca

stbrody merged commit c9438bd into ceramicnetwork:develop Jun 2, 2021

achingbrain deleted the achingbrain/ipfs-w-types branch June 5, 2021 13:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update ipfs (now with typing) dependencies #1337

chore: update ipfs (now with typing) dependencies #1337

achingbrain commented Apr 30, 2021

oed commented Apr 30, 2021

achingbrain commented Apr 30, 2021

achingbrain commented Apr 30, 2021

oed commented Apr 30, 2021

achingbrain commented Apr 30, 2021

oed commented Apr 30, 2021

oed commented Apr 30, 2021

achingbrain commented Apr 30, 2021

achingbrain commented May 2, 2021

stbrody left a comment

achingbrain commented May 4, 2021

achingbrain commented May 12, 2021

oed left a comment

oed Jun 2, 2021

oed Jun 2, 2021

achingbrain Jun 2, 2021

oed commented Jun 2, 2021

stbrody Jun 2, 2021

oed Jun 2, 2021

stbrody Jun 2, 2021

stbrody commented Jun 2, 2021

		import type { IPFS } from 'ipfs-core-types'
		export type IpfsApi = IPFS

chore: update ipfs (now with typing) dependencies #1337

chore: update ipfs (now with typing) dependencies #1337

Conversation

achingbrain commented Apr 30, 2021

oed commented Apr 30, 2021

achingbrain commented Apr 30, 2021

achingbrain commented Apr 30, 2021

oed commented Apr 30, 2021

achingbrain commented Apr 30, 2021

oed commented Apr 30, 2021

oed commented Apr 30, 2021

achingbrain commented Apr 30, 2021

achingbrain commented May 2, 2021

stbrody left a comment

Choose a reason for hiding this comment

achingbrain commented May 4, 2021

achingbrain commented May 12, 2021

oed left a comment

Choose a reason for hiding this comment

oed Jun 2, 2021

Choose a reason for hiding this comment

oed Jun 2, 2021

Choose a reason for hiding this comment

achingbrain Jun 2, 2021

Choose a reason for hiding this comment

oed commented Jun 2, 2021

stbrody Jun 2, 2021

Choose a reason for hiding this comment

oed Jun 2, 2021

Choose a reason for hiding this comment

stbrody Jun 2, 2021

Choose a reason for hiding this comment

stbrody commented Jun 2, 2021