Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty value1,2 and 3 at action/control/condition levels if not needed (to avoid failing decode) #2038

Closed
RobertoAbraul opened this issue Nov 14, 2019 · 5 comments

Comments

@RobertoAbraul
Copy link

Hi,

we found a strange situation.
We had a condition on an action that we don't wanna use it anymore.

Before:
image

So we ignore the conditions to compare and set the condition to be exectuted always.

Now:
image

Besides condition is set to "always" cerberus is trying to compare "Condition Value1" and "Condition Value2".

image

Is this expected?
It is a strange situation because on "always" condition we cannot set value1 or value2 but Cerberus seems to be trying to use the old values.

Can you please take a look and clarify?

Cerberus4.4-SNAPSHOT-1440 in prd

Thanks!

@cDelage
Copy link
Collaborator

cDelage commented Nov 15, 2019

Cerberus will not use your old values,
It stock parameters values, but it don't take in consideration this.
It's not clean to display it in my opinion, but it not impact your test.

@RobertoAbraul
Copy link
Author

Hi @cDelage ,

as you can see in my image it fails when I leave the old values in "always" condition.
Test case/action is only ok after remove the old values.

Thanks

@vertigo17
Copy link
Member

@RobertoAbraul , what happen here is that even if 'always' condition does not require any parameter, parameters are still defined in the database and Cerberus tries to decode them. Decode error consequently still raise.
This is not a good behaviour and deserve a fix.
What we will do is leave the parameters defined (so that in case you change back the operator, you don't have to key them again) but empty them at execution level when not required so that it does not get decoded.

@vertigo17
Copy link
Member

As a workaround you can of course empty them by temporary changing the operator.

@vertigo17 vertigo17 changed the title Condition Operator - Always Empty variables at action/control/condition levels if not needed (to avoid failing decode) Aug 19, 2021
@vertigo17 vertigo17 changed the title Empty variables at action/control/condition levels if not needed (to avoid failing decode) Empty value1,2 and 3 at action/control/condition levels if not needed (to avoid failing decode) Aug 19, 2021
@ittaLaRedoute
Copy link

Hi @vertigo17 any news on that ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants