Use groupcache pool for state db access #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwinphatak
force-pushed
the
ashwinp-group-cache
branch
2 times, most recently
from
6103e4a
to
26af75c
Compare
i-norden
approved these changes
Sep 3, 2021
pkg/eth/backend.go
Outdated
| "github.com/vulcanize/ipld-eth-server/pkg/shared" | ||
|
|
||
| validator "github.com/vulcanize/eth-ipfs-state-validator/pkg" |
There was a problem hiding this comment.
I can't find anything useful to comment on, but we could clean up some of the imports here and elsewhere so that it remains three sections for these three types
standard lib
external deps
internal deps
|
looks like build is failing due to using local replace of the ipld-eth-indexer dependency, which we are moving away from in #92 Also need to cut a new release of ipfs-ethdb with the groupcache stuff in it, as you know. |
arijitAD
force-pushed
the
ashwinp-group-cache
branch
from
273c6d1
to
52bd492
Compare
ashwinphatak
changed the title
arijitAD
force-pushed
the
ashwinp-group-cache
branch
from
0bb79b2
to
d35d381
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/vulcanize/ops/issues/63