-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use groupcache pool for state db access #91
Conversation
6103e4a
to
26af75c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, couldn't find anything to comment on
pkg/eth/backend.go
Outdated
"github.com/vulcanize/ipld-eth-server/pkg/shared" | ||
|
||
validator "github.com/vulcanize/eth-ipfs-state-validator/pkg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find anything useful to comment on, but we could clean up some of the imports here and elsewhere so that it remains three sections for these three types
standard lib
external deps
internal deps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
looks like build is failing due to using local replace of the ipld-eth-indexer dependency, which we are moving away from in #92 Also need to cut a new release of ipfs-ethdb with the groupcache stuff in it, as you know. |
273c6d1
to
52bd492
Compare
0bb79b2
to
d35d381
Compare
Part of https://github.com/vulcanize/ops/issues/63