FIX: replace origin by dynamic value in CI pipeline #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzah
changed the title
added 2 commits
January 10, 2023 16:52
rely on actions/checkout@v3 to propoerly checkout the branch
added 7 commits
January 10, 2023 17:32
|
It looks like it's currently impossible to get the fork name from where the Pull request was requested in the github action workflow. So we can't checkout the branch and commit update automatically. A workaround would be to trigger an specific workflow on push events on master after the PR merge, thus creating a new PR with the commits (logo update + API generation), but this is not satisfactory to me. In the meantime, PR coming from forks should be doubled checked before merging and the checks can be ignored. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix CI when running on a fork of icclim.