Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run 'make klone-upgrade' and fix broken generator flags #71

Merged
merged 1 commit into from
May 21, 2024

Conversation

inteon
Copy link
Member

@inteon inteon commented May 19, 2024

defaulter-gen and conversion-gen's flags changed.
I had to update the makefile to pass the new flags to these tools.

Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@ThatsMrTalbot
Copy link
Contributor

/lgtm

@inteon
Copy link
Member Author

inteon commented May 21, 2024

/approve

@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot merged commit 2698a0c into main May 21, 2024
5 checks passed
@SgtCoDFish SgtCoDFish deleted the upgrade_klone branch May 21, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants