Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add erikgb as maintainer #32

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

inteon
Copy link
Member

@inteon inteon commented Jul 15, 2024

Erik (@erikgb) has been an important contributor to cert-manager and more specifically trust-manager.

  • The improvements Erik has made to trust-manager have improved the project's usefulness and correctness (he has both contributed directly through PRs and indirectly by reviewing PRs).
  • Erik also contributed to other controllers like approver-policy and cert-manager.
  • He has been joining a lot of our stand-ups and is a trustworthy contributor.

Adding Erik as a maintainer will diversify our maintainers team and it will allow us to give him admin privileges on the trust-manager project, so he can cut releases of trust-manager when required (see https://github.com/cert-manager/community/blob/main/GOVERNANCE.md for requirements wrt. admins).

I (@inteon) think @erikgb is an important part of our community and for that reason must receive the privileges required to contribute optimally. I would trust @erikgb with more admin privileges, but think it is better to restrict his privileges to the actions he is interested in (in case of compromise of his account), additionally this will reduce the scope of the perceived responsibilities that come with these privileges (both for Erik and the rest of the community, eg. no one will ping him to do a cert-manager release).

I'd like us to approve this appointment using lazy consensus:

🧑‍💻 Participants: @cert-manager-maintainers
📢 Deadline: July 19th, 2024 23:59 UTC
🚨 Note: to speed up the process, you may answer with a 👍 or a comment stating that you are lazy to help reach consensus before the deadline.

Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 15, 2024
@SgtCoDFish
Copy link
Member

Erik has been the MVP of the cert-manager community for a long time. He's active in meetings, highly knowledgable, and a good person to chat to.

I fully support his nomination and I fully support this proposal 👍

@inteon
Copy link
Member Author

inteon commented Jul 24, 2024

NOTE: this vote has been accepted.

I'm on holiday right now, so I won't be able to make the administrative changes until I'm back. Other maintainers might be able to make them sooner.

@SgtCoDFish
Copy link
Member

Erik is also on holiday at the moment, so there's no great rush on this!

@maelvls
Copy link
Member

maelvls commented Aug 13, 2024

Pre-Onboarding Checklist — info to be requested to the new maintainer:

  • New maintainer's email: ...
  • New maintainer's GitHub ID: @erikgb
  • New maintainer's Kubernetes Slack ID (see here for how to get it): ...

Onboarding Checklist — tasks to be performed by an existing maintainer:

Onboarding Maintainer: @inteon

Don't forget to add the links to the various PRs or IT tickets as you complete the tasks, and add any missing item.

Initial Privileges:

Self-access Privileges:

  • Go over the list of self-service privileges the new maintainer can get access to by showing them the infrastructure README. Let them know that they can admin access to any of these services by opening a ticket at servicedesk.cncf.io.

Privileges added outside of the CNCF Service Desk:

These are the list of privileges that weren't asked through a ticket at servicedesk.cncf.io because this service isn't owned by the CNCF yet.

@maelvls
Copy link
Member

maelvls commented Aug 13, 2024

@inteon Thanks for taking care of the onboarding checklist. Feel free to edit the checklist message above with your progress (PR link, etc) sor any additional steps that isn't in the list.

@maelvls
Copy link
Member

maelvls commented Aug 26, 2024

Not sure why this PR hasn't been merged yet 😅

The lazy-consensus vote ended on July 19th, 2024, which means this PR can be approved.

/lgtm
/approve

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2024
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelvls

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2024
@cert-manager-prow cert-manager-prow bot merged commit 822e5f3 into main Aug 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants