node-driver-registrar preStop hook fails

[basert]

Hey,

we are seeing issues in our kubelet error logs when we shutdown a node. The preStop hook (

csi-driver/deploy/charts/csi-driver/templates/daemonset.yaml

Line 25 in 397cac4

command: ["/bin/sh", "-c", "rm -rf /registration/cert-manager-csi-driver /registration/cert-manager-csi-driver-reg.sock"]

) for the node-driver-registrar fails as the container image does not include /bin/sh binary: https://github.com/kubernetes-csi/node-driver-registrar/blob/master/Dockerfile

[JoshVanL]

Thanks for the case @basert! Looking at kubernetes-csi/node-driver-registrar#21 and kubernetes-csi/node-driver-registrar#61, it looks like we can safely remove the preStop hook altogether.

I'll create a PR for that now, as well as release a new helm chart release containing this change.

/assign

[basert]

Hey Josh, can you let me know when you plan to release the change?

[JoshVanL]

@basert done! 🙂