Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove life cycle hook from Daemonset #110

Merged
merged 2 commits into from
Aug 24, 2022
Merged

Remove life cycle hook from Daemonset #110

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd1825d
Remove the life cycle pre stop hook as it is not needed
JoshVanL Aug 16, 2022
be42e88
Updates the helm Chart version to v0.4.1
JoshVanL Aug 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions deploy/charts/csi-driver/templates/daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@ spec:
- name: node-driver-registrar
image: "{{ .Values.nodeDriverRegistrarImage.repository }}:{{ .Values.nodeDriverRegistrarImage.tag }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
lifecycle:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, why was this needed before? and why it's no longer needed..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the issue here

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 🤦‍♂️ :)

preStop:
exec:
command: ["/bin/sh", "-c", "rm -rf /registration/cert-manager-csi-driver /registration/cert-manager-csi-driver-reg.sock"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This command removes both plugin (?) and socket whereas the fix in kubernetes-csi/node-driver-registrar#61 seems to only remove the socket- do we think that might be an issue?

I do see that the kubernetes-csi/node-driver-registrar#61 removes this command from the example deployment, so assume that this is considered no longer needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That it my understanding as well.

args:
- -v={{ .Values.app.logLevel }}
- --csi-address=/plugin/csi.sock
Expand Down