Add bootstrap script and e2e tests #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cert-manager-prow
bot
added
dco-signoff: yes
inteon
force-pushed
the
bootstrap_and_tests
branch
from
196dd52
to
b34d107
Compare
cert-manager-prow
bot
added
size/L
inteon
force-pushed
the
bootstrap_and_tests
branch
4 times, most recently
from
62e3c51
to
580bd50
Compare
cert-manager-prow
bot
added
dco-signoff: no
inteon
force-pushed
the
bootstrap_and_tests
branch
from
580bd50
to
5370852
Compare
cert-manager-prow
bot
added
dco-signoff: yes
inteon
force-pushed
the
bootstrap_and_tests
branch
3 times, most recently
from
3619eda
to
9e621ff
Compare
inteon
force-pushed
the
bootstrap_and_tests
branch
3 times, most recently
from
ee60110
to
43cec26
Compare
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
inteon
force-pushed
the
bootstrap_and_tests
branch
from
3f3fa55
to
091cbfd
Compare
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
inteon
force-pushed
the
bootstrap_and_tests
branch
from
091cbfd
to
595f7c5
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a bootstrap script that can be used to quickly setup makefile modules for a project.
We also use this bootstrap script to bootstrap our end-to-end tests.
These end-to-end tests should make it easier to change the makefile modules and prevent accidental breakage.
Also includes two fixes for issues found through the new test:
skip_license_checkheader had a trailing space causing it to fail.tputcausedmake helpto fail when TERM was not set properly