Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add W5100 driver #2990

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Add W5100 driver #2990

merged 1 commit into from
Dec 17, 2024

Conversation

robertc2000
Copy link
Collaborator

No description provided.

@robertc2000 robertc2000 requested a review from scaprile December 17, 2024 11:50
@robertc2000 robertc2000 assigned robertc2000 and cpq and unassigned robertc2000 Dec 17, 2024
@robertc2000 robertc2000 requested a review from cpq December 17, 2024 11:50
Copy link
Collaborator

@scaprile scaprile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty close to W5500, yet it looks like merging them won't look readable.

Please rebase to get rid of those formatting changes in mongoose.c

@robertc2000
Copy link
Collaborator Author

robertc2000 commented Dec 17, 2024

  1. It's the same approach as W5500, but there are too many differences, especially in SPI command format and registers. So, it's best to keep the drivers in separate files.
  2. It's already rebased. Looks like there is a weird issue with formatting in the mongoose.c file from 'master' branch

    mongoose/mongoose.c

    Lines 6442 to 6444 in 4a164c3

    MG_IRAM static bool mg_stm32f_write(void *addr,
    const void *buf,
    size_t len) {
    After rebuilding mongoose.c, the format appears to be fixed.

@robertc2000 robertc2000 merged commit b0b0dd9 into master Dec 17, 2024
62 of 78 checks passed
@robertc2000 robertc2000 deleted the w5100 branch December 17, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants