Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add user profile #321

Merged
merged 14 commits into from
Aug 19, 2023
Merged

feat: add user profile #321

merged 14 commits into from
Aug 19, 2023

Conversation

joaodiaslobo
Copy link
Member

Closes #297

@joaodiaslobo joaodiaslobo added enhancement New feature or improvements frontend Frontend related backend Backend related labels Aug 17, 2023
@joaodiaslobo joaodiaslobo added this to the 1.0 version milestone Aug 17, 2023
@joaodiaslobo joaodiaslobo self-assigned this Aug 17, 2023
@MarioRodrigues10
Copy link
Member

Also make sure, to provide some unit tests to test this feature 💡

@MarioRodrigues10
Copy link
Member

This is looking good, what is missing to finish the PR?

@joaodiaslobo
Copy link
Member Author

This is looking good, what is missing to finish the PR?

Just wanted to add some finishing touches, should be ready for review now!

@joaodiaslobo joaodiaslobo marked this pull request as ready for review August 19, 2023 14:36
@joaodiaslobo joaodiaslobo requested review from a team and ruilopesm August 19, 2023 14:36
ruilopesm
ruilopesm reviewed Aug 19, 2023
View reviewed changes
Copy link
Member

@ruilopesm ruilopesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
I don't like this edit button, but can't think of something else 😅
Do you have any idea?

@joaodiaslobo
Copy link
Member Author

image I don't like this edit button, but can't think of something else 😅 Do you have any idea?

@RuiL1904 Using other buttons as reference we can also have something like this:

image

What do you think? 🤔

@joaodiaslobo joaodiaslobo mentioned this pull request Aug 19, 2023
Closed
@ruilopesm
Copy link
Member

@joaodiaslobo Its way better. Push the code, in order to see it on mobile and review it 🙏🏼

ruilopesm
ruilopesm approved these changes Aug 19, 2023
View reviewed changes
Copy link
Member

@ruilopesm ruilopesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@joaodiaslobo joaodiaslobo enabled auto-merge (squash) August 19, 2023 16:55
@joaodiaslobo joaodiaslobo merged commit 35dbb05 into develop Aug 19, 2023
3 checks passed
@joaodiaslobo joaodiaslobo deleted the jl/add-user-profile branch August 19, 2023 16:57
@MarioRodrigues10 MarioRodrigues10 mentioned this pull request Aug 22, 2023
Open
2 tasks
@ruilopesm ruilopesm removed this from the 1.0.0 milestone Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruilopesm ruilopesm ruilopesm approved these changes

@MarioRodrigues10 MarioRodrigues10 Awaiting requested review from MarioRodrigues10

Assignees

@joaodiaslobo joaodiaslobo

Labels
backend Backend related enhancement New feature or improvements frontend Frontend related
Projects
Atomic - Development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User profile page
3 participants
@joaodiaslobo @MarioRodrigues10 @ruilopesm