Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Add fade animation to cards #42

Merged
merged 3 commits into from
Apr 5, 2022
Merged

🎨 Add fade animation to cards #42

merged 3 commits into from
Apr 5, 2022

Conversation

RicAlvesO
Copy link
Contributor

If applied will add a new animation to selected/hovered cards in the cesium.link website.

@vercel
Copy link

vercel bot commented Mar 19, 2022

@RicAlvesO is attempting to deploy a commit to the CeSIUM Team on Vercel.

A member of the Team first needs to authorize it.

@netlify
Copy link

netlify bot commented Mar 19, 2022

Deploy Preview for cesium-link failed.

Name Link
🔨 Latest commit 85b9d78
🔍 Latest deploy log https://app.netlify.com/sites/cesium-link/deploys/624aa92fea8d710008d4cd27

@nelsonmestevao nelsonmestevao self-requested a review April 3, 2022 19:39
@nelsonmestevao nelsonmestevao changed the title 🎨 Added fade animation to cards 🎨 Add fade animation to cards Apr 3, 2022
@vercel
Copy link

vercel bot commented Apr 3, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/cesiuminho/cesium-link/vdCEEuMxf7LysFxGLisdhQS7Ly7i
✅ Preview: https://cesium-link-git-fork-ricalveso-csschanges-cesiuminho.vercel.app

@@ -11,14 +12,15 @@
text-decoration: none;
border: 1px solid #eaeaea;
border-radius: 10px;
transition: color 0.15s ease, border-color 0.15s ease;
transition: color 0.5s ease, background-color 0.5s ease, border-color 0.5s ease;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These much transition time makes the website feel slow. Could you try a smaller value, please?

.card:hover {
color: white;
border-color: white;
background-color: orange;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the upgrade to orange to make it more consist with our branding. However, I dislike the orange fill. Could you try orange as border color?

What about adding some animation effect on mouse hover, live rotating, shaking or something else?

Copy link
Member

@nelsonmestevao nelsonmestevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first contribution 🧡

Could you check my comments, please? 🙏

@RicAlvesO
Copy link
Contributor Author

Following the much appreciated feedback the button animation was changed. Transitions are back to .15s and background color is back to white.

As suggested, border and text color are now orange to be more in line with the brand, the new animation makes the orange color slide through the button as the color changes, disappearing right after.

Copy link
Member

@nelsonmestevao nelsonmestevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Thanks again for this 🙏

@nelsonmestevao nelsonmestevao merged commit c4ad7a9 into cesium:main Apr 5, 2022
@RicAlvesO RicAlvesO deleted the css_changes branch April 9, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants