build: Migrate views to Phoenix 1.7 #343
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruioliveira02
requested review from
ruilopesm,
MarioRodrigues10,
danielsp45 and
joaodiaslobo
ruioliveira02
force-pushed
the
ro/migrate-views
branch
from
fd76a63
to
56bf6e2
Compare
|
@ruioliveira02 I agree. |
MarioRodrigues10
requested changes
Sep 14, 2023
ruilopesm
force-pushed
the
ro/migrate-views
branch
from
8d5fe77
to
0133865
Compare
ruioliveira02
force-pushed
the
ro/migrate-views
branch
from
0133865
to
307b713
Compare
MarioRodrigues10
requested changes
Nov 28, 2023
| token_balance: at.token_balance, | ||
| prizes: for(p <- at.prizes, do: PrizeJSON.prize_attendee(%{prize: p})), | ||
| entries: at.entries, | ||
| redeemables: for(r <- at.redeemables, do: RedeemableJSON.my_readeemables(%{redeemable: r})) |
There was a problem hiding this comment.
Suggested change
| redeemables: for(r <- at.redeemables, do: RedeemableJSON.my_readeemables(%{redeemable: r})) | |
| redeemables: for(r <- at.redeemables, do: RedeemableJSON.my_redeemables(%{redeemable: r})) |
Fix the typo in this line
MarioRodrigues10
requested changes
Nov 29, 2023
Comment on lines
33
to
35
| def render("price.json", %{price: price}) do | ||
| %{price: price} | ||
| end |
There was a problem hiding this comment.
I think is due to this function you should create
def price(%{price: price}) do
%{price: price}
end
ruioliveira02
force-pushed
the
ro/migrate-views
branch
from
4e8ee4f
to
16499f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #339.
Admin controllers aren't migrated. I think we should remove them and start from scratch there. What do you think @RuiL1904 @MarioRodrigues10 ?