Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: align landing footer #573

Merged
merged 4 commits into from
Nov 14, 2023
Merged

refactor: align landing footer #573

merged 4 commits into from
Nov 14, 2023

Conversation

Darguima
Copy link
Contributor

Landing Footer Fixed. Please just note that the right texts of the footer have different behavior about the wrap, that as far as I know, isn't so easy to fix it with just css. Although there isn't any text overflow and the align is fixed.

2023-11-10.17-15-41.mp4

Issue: #500

Copy link

netlify bot commented Nov 10, 2023

Deploy Preview for seium-stg ready!

Name Link
🔨 Latest commit 97f84ef
🔍 Latest deploy log https://app.netlify.com/sites/seium-stg/deploys/655118f0d6a5730008502fa3
😎 Deploy Preview https://deploy-preview-573--seium-stg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Darguima Darguima removed the request for review from ruioliveira02 November 10, 2023 17:30
@joaodiaslobo joaodiaslobo changed the title Align landing footer style: align landing footer Nov 10, 2023
@ruilopesm ruilopesm added the enhancement New feature or request label Nov 11, 2023
@ruilopesm ruilopesm linked an issue Nov 11, 2023 that may be closed by this pull request
@ruilopesm ruilopesm changed the title style: align landing footer refactor: align landing footer Nov 11, 2023
Copy link
Member

@ruilopesm ruilopesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding text-center whitespace-nowrap will lead to a more consistent text positioning. Try it out and return feedback 💪🏼

@Darguima
Copy link
Contributor Author

I think adding text-center whitespace-nowrap will lead to a more consistent text positioning. Try it out and return feedback 💪🏼

The problem is that the space isn't enough to show all the text, so the text-center can't work properly. I will try to better fit the content and give some feedback

image

@Darguima
Copy link
Contributor Author

The text alignment seems be the problem. I changed it to be aligned to the start/left and with the no wrap . Now we don't see the inconsistent on wrap or alignment.

I changed the position of the links to try create a better alignment. What do you think now?
I think that the only problem now is that the icons at the bottom are aligned to right, and they will be aligned with the bottom right Link, but not with the right top Link

2023-11-12.18-24-10.mp4

@Darguima Darguima merged commit 0a14023 into main Nov 14, 2023
5 checks passed
@Darguima Darguima deleted the dg/align_landing_footer branch November 14, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align landing footer
2 participants