forked from bytecodealliance/wasmtime
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix uextend on x64 for non-i32-source cases. (bytecodealliance#3906)
In bytecodealliance#3849, I moved uextend over to ISLE in the x64 backend. Unfortunately, the lowering patterns had a bug in the i32-to-i64 special case (when we know the generating instruction zeroes the upper 32 bits): it wasn't actually special casing for an i32 source! This meant that e.g. zero extends of the results of i8 adds did not work properly. This PR fixes the bug and updates the runtest for extends significantly to cover the narrow-value cases. No security impact to Wasm as Wasm does not use narrow integer types. Thanks @bjorn3 for reporting!
- Loading branch information
Showing
4 changed files
with
310 additions
and
114 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
cranelift/codegen/src/isa/x64/lower/isle/generated_code.manifest
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
src/clif.isle 9ea75a6f790b5c03 | ||
src/prelude.isle b2bc986bcbbbb77 | ||
src/isa/x64/inst.isle 40f495d3ca5ae547 | ||
src/isa/x64/lower.isle faa2a07bba48a813 | ||
src/isa/x64/lower.isle c049f7d36db0e0fb |
186 changes: 96 additions & 90 deletions
186
cranelift/codegen/src/isa/x64/lower/isle/generated_code.rs
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.