Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable linter in CI #1

Closed
wants to merge 2 commits into from
Closed

Disable linter in CI #1

wants to merge 2 commits into from

Conversation

cffls
Copy link
Owner

@cffls cffls commented Aug 9, 2023

Description

Please provide a detailed description of what was done in this PR

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2023

Codecov Report

Patch coverage: 54.54% and project coverage change: +0.29% 🎉

Comparison is base (0fc121b) 56.88% compared to head (88ea699) 57.17%.
Report is 1784 commits behind head on develop.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop       #1      +/-   ##
===========================================
+ Coverage    56.88%   57.17%   +0.29%     
===========================================
  Files          606      633      +27     
  Lines        70128    77324    +7196     
===========================================
+ Hits         39890    44212    +4322     
- Misses       26831    29351    +2520     
- Partials      3407     3761     +354     
Files Changed Coverage Δ
accounts/abi/bind/auth.go 0.00% <ø> (ø)
accounts/abi/bind/backends/bor_simulated.go 8.33% <ø> (ø)
accounts/abi/bind/bind.go 0.00% <0.00%> (-81.03%) ⬇️
accounts/abi/bind/util.go 80.00% <ø> (ø)
accounts/abi/error.go 64.28% <ø> (ø)
accounts/abi/error_handling.go 81.81% <ø> (ø)
accounts/abi/event.go 100.00% <ø> (ø)
accounts/abi/method.go 95.55% <ø> (ø)
accounts/abi/pack.go 77.77% <ø> (ø)
accounts/abi/topics.go 95.18% <ø> (ø)
... and 26 more

... and 577 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

This PR is stale because it has been open 21 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

This PR is stale because it has been open 21 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 4, 2023
@github-actions
Copy link

This PR was closed because it has been stalled for 35 days with no activity.

@github-actions github-actions bot closed this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants