-
Notifications
You must be signed in to change notification settings - Fork 41
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Look for JSHint config info in jshintConfing property of package.json. #26
Comments
Do you know offhand what takes priority - .jshintrc or package.json? On Sun, Dec 1, 2013 at 4:28 AM, Tobie Langel notifications@git.luolix.topwrote:
Raymond Camden, Adobe Developer Evangelist Email : raymondcamden@gmail.com |
I don't. I was wondering about the precedence issue myself. I'm also suspecting JSHint must have a module that handles that already. Why not tap into it to determine config options? |
I'm just using the core library so I can easily pass in the code string and On Sun, Dec 1, 2013 at 8:05 AM, Tobie Langel notifications@git.luolix.topwrote:
Raymond Camden, Adobe Developer Evangelist Email : raymondcamden@gmail.com |
👍 |
It's actually the other way around. Config found in |
I'd happily accept a pull request for this then. To me it seems a bit On Fri, Jan 24, 2014 at 5:34 PM, Mark S. Everitt
Raymond Camden, Web Developer for Adobe Email : raymondcamden@gmail.com |
Cool. I'll prepare a pull request for you. I took a look the other day, but no access to the Node |
I've opened a pull request, but I really need to debug this properly. I'm probably being daft, but how can I see the output from |
In Brackets, Debug menu, show developer tools. On Mon, Jan 27, 2014 at 8:21 PM, Mark S. Everitt
Raymond Camden, Web Developer for Adobe Email : raymondcamden@gmail.com |
Weird. I didn't have much luck with that. It's late though. I'll sleep on it and return with a fresh mind. |
@cfjedimaster @qubyte I believe that "proper" (node-jshint-like) config file handling should be done once Brackets supports async linting (i.e. adobe/brackets#5137 comes through). it will be done along with .jshintrc lookup (possibly using new preferences model which supports config file lookups). @cfjedimaster could it wait until then? |
Will the feature as implemented here cause problems later on? |
i do believe that the implementation is not quite appropriate -- it changes a lot of code where it shouldn't have. looks more like refactoring. i left a comment in #34. |
Minor correction: the actual pending PR is adobe/brackets#6530. The other is the link to the original issue (one of the many). |
The refactoring is mainly to avoid code duplication. I could just have copy-pasted-modified the existing promise and chained them together later on, but that would look messy IMO. I will defer to @cfjedimaster though. |
@busykai back to the question... Will this cause problems with respect to adobe/brackets#6530 later on? |
let's discuss code next to it.. see #34. |
Add support for reading properties from package.json. It takes priority over .jshintrc.
Keep track of currently used file and reload it when it changes.
JSHint supports config info set in the
jshintConfing
property ofpackage.json
. Would be nifty if Brackets supported that too.More details here (scroll down to "Configuration").
The text was updated successfully, but these errors were encountered: