Resolve minor issues with satellite template #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scotchester
reviewed
Aug 25, 2020
Comment on lines
+30
to
+31
| with: | ||
| fetch-depth: 0 |
There was a problem hiding this comment.
This change was necessary due to a change in checkout@v2 that defaults to shallow cloning with no tags. I have opened a feature request issue to ask for the option to shallow clone but also pull down tags.
willbarton
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple bugs with our current satellite template.
It runs on every commit pushed and all PR's so the tests run twice, now it will only run on commits to main/master.
It doesn't properly map tox-env to the python version, so updating the keys so they match.
It currently fails with tox, as it needs tags as part of our cfpb-setup, so now it clones the repo with all tags.