Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

django-opensearch-dsl Implementation #7192

Merged
merged 56 commits into from
Aug 26, 2022
Merged

django-opensearch-dsl Implementation #7192

merged 56 commits into from
Aug 26, 2022

Conversation

Colin-Seifer
Copy link
Contributor

Changes Elasticsearch to target django-opensearch-dsl on the backend. Includes changes to helm which support a full switch over to Opensearch in the future. Contrary to the branch name, this does NOT change anything with the ccdb5 api. The branch was initially made to run tests on that, but in order to do so, I needed to bring the opensearch branch up to date. This only includes changes to the opensearch branch and targeting django-opensearch-dsl.

Additions

  • Added support for django-opensearch-dsl
  • Added future support for switch to Opensearch

Removals

  • Removes backend support for django-elasticsearch-dsl

Changes

  • Queries are slightly slower, so I added some sleep calls in tests to make sure data is available before it's used.

How to test this PR

  1. Ensure all tests still pass

Checklist

  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • Consider prefixing, e.g., "Mega Menu: fix layout bug", or "Docs: Update Docker installation instructions".
  • Changes are limited to a single goal (no scope creep)
  • Code follows the standards laid out in the CFPB development guidelines

@jslay-excella jslay-excella changed the base branch from main to opensearch August 22, 2022 20:28
@jslay-excella jslay-excella changed the base branch from opensearch to main August 22, 2022 20:28
@jslay-excella jslay-excella mentioned this pull request Aug 24, 2022
19 tasks
@Colin-Seifer Colin-Seifer merged commit e6d7eb2 into main Aug 26, 2022
@Colin-Seifer Colin-Seifer deleted the ccdb5-api-opensearch branch August 26, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants