Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FormModel: remove false || #8620

Merged
merged 1 commit into from
Oct 30, 2024
Merged

FormModel: remove false || #8620

merged 1 commit into from
Oct 30, 2024

Conversation

anselmbradford
Copy link
Member

This doesn't seem like it is needed? It looks like isInGroup will always have a value that it passes to _getLabelText, which has an if/else statement that checks isInGroup' value.

Changes

  • FormModel: remove false ||

How to test this PR

  1. PR checks should pass.
  2. /blog should work as before.

wpears
wpears approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@wpears wpears left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, what a strange construction! false || will.. always just return the right hand value. No idea what was happening here.

@anselmbradford anselmbradford added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit 7382c33 Oct 30, 2024
11 checks passed
@anselmbradford anselmbradford deleted the ans_form_model branch October 30, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpears wpears wpears approved these changes

@contolini contolini Awaiting requested review from contolini

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anselmbradford @wpears