Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove for attribute from pagination label #8629

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

anselmbradford
Copy link
Member

According to https://developer.mozilla.org/en-US/docs/Web/HTML/Element/label

you can nest the directly inside the , in which case the for and id attributes are not needed because the association is implicit:

Removals

  • Remove for attribute from pagination label.

How to test this PR

  1. Run local server and visiting /blog and /data-research/prepaid-accounts/search-agreements/ and interact with the pagination and see that you can click the text next to the page number input to go to the input.

Notes and todos

  • The input IDs get some use in the Cypress tests, but maybe those could be pointed to something else and the IDs could be removed overall.

@anselmbradford anselmbradford added this pull request to the merge queue Nov 6, 2024
Merged via the queue into main with commit b529d44 Nov 6, 2024
17 checks passed
@anselmbradford anselmbradford deleted the ans_pagination_labels branch November 6, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants