Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete unused analytics script #8632

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Delete unused analytics script #8632

merged 2 commits into from
Nov 13, 2024

Conversation

anselmbradford
Copy link
Member

@anselmbradford anselmbradford commented Nov 7, 2024 •
edited
Loading

Removals

  • Delete unused analytics script

How to test this PR

  1. Paul to confirm these are the right files.

@anselmbradford
Copy link
Member Author

Ohhhhhhh @paulhyland I just realized that bah-explainers.js isn't used directly, but it's imported by bah-closing-disclosure-listeners.js and bah-loan-estimate-listeners.js. Those two files are identical, except they each pass in a different label to bah-explainers.js

@anselmbradford anselmbradford changed the title Delete unused analytics scripts Delete unused analytics script Nov 7, 2024
paulhyland
paulhyland approved these changes Nov 13, 2024
View reviewed changes
Copy link

@paulhyland paulhyland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is OK to delete.

@anselmbradford anselmbradford added this pull request to the merge queue Nov 13, 2024
Merged via the queue into main with commit 64f8e9d Nov 13, 2024
11 checks passed
@anselmbradford anselmbradford deleted the ans_analytics_scripts branch November 13, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulhyland paulhyland paulhyland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anselmbradford @paulhyland