Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to DS@3.4.8 and update buttons and pagination, etc #8635

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

anselmbradford
Copy link
Member

@anselmbradford anselmbradford commented Nov 12, 2024

Changes

  • Update buttons and pagination to use new flex-based layouts and remove button icon-related class names.
  • Use u-small-text--subtle from the DS.
  • Migrate attach to behaviorAttach.

How to test this PR

  1. Check prepaid products agreements db and check that the pagination looks fine.
  2. Check the disclosures tool and see that the button group for navigating steps has the buttons properly spaced apart and that the step 2 loading icon is on the right.
  3. Check the gradpath tool and see that the navigation buttons have centered text and are unchanged to prod.
  4. Check the Before You Claim tool and enter dob and income amounts and see that the loading icon on the submit button works.
  5. Check http://localhost:8000/privacy/disclosure-consent/ and http://localhost:8000/privacy/records-access/ form and edit the submit button (or submit test data) to see that loading icon appears when the a-btn--hide-icon class is removed.
  6. Check video close button after playing a video, such as http://localhost:8000/about-us/blog/addressing-racial-inequities-consumer-finance-markets/
  7. Check </> buttons on http://localhost:8000/owning-a-home/loan-estimate/

Screenshots

Before:

Screenshot 2024-11-12 at 8 37 25 AM Screenshot 2024-11-12 at 8 43 33 AM Screenshot 2024-11-12 at 8 50 16 AM

After:

Screenshot 2024-11-12 at 8 36 47 AM Screenshot 2024-11-12 at 8 43 39 AM Screenshot 2024-11-12 at 8 48 41 AM

@anselmbradford anselmbradford changed the title Update buttons and pagination Update to DS@3.4.5 and update buttons and pagination, etc Nov 12, 2024
@paulhyland
Copy link

@anselmbradford - checked all the file updates and none of them affect our GTM triggers. For buttons, we only look for the classes a-btn and btn (the latter used by Mosaic).

So I approve from my end, but since I don't know if one of the other reviewers needs to run the tests under "How to test this PR", I'm not approving/triggering the merge.

@anselmbradford anselmbradford force-pushed the ans_update_ds branch 3 times, most recently from d6af260 to 5d2d90d Compare November 13, 2024 16:30
@anselmbradford anselmbradford changed the title Update to DS@3.4.5 and update buttons and pagination, etc Update to DS@3.4.6 and update buttons and pagination, etc Nov 13, 2024
@anselmbradford
Copy link
Member Author

Reviewers, the SonarCloud failure is for the heavy amount of duplication between https://www.consumerfinance.gov/privacy/disclosure-consent/ and https://www.consumerfinance.gov/privacy/records-access/, which predates this PR.

@wpears
Copy link
Member

wpears commented Nov 13, 2024

The video button looks weird to me, see:
Screenshot 2024-11-13 at 10 36 32 AM

Seems like the icon should be to the right of the vertical line or the vertical line should not exist.

@anselmbradford
Copy link
Member Author

The video button looks weird to me, see:

Fixed!

@anselmbradford
Copy link
Member Author

FYI I force pushed

@anselmbradford anselmbradford changed the title Update to DS@3.4.6 and update buttons and pagination, etc Update to DS@3.4.8 and update buttons and pagination, etc Nov 13, 2024
Copy link
Member

@wpears wpears left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

@anselmbradford anselmbradford added this pull request to the merge queue Nov 13, 2024
Merged via the queue into main with commit 2fcb407 Nov 13, 2024
16 of 17 checks passed
@anselmbradford anselmbradford deleted the ans_update_ds branch November 13, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants