-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to DS@3.4.8 and update buttons and pagination, etc #8635
Conversation
@anselmbradford - checked all the file updates and none of them affect our GTM triggers. For buttons, we only look for the classes a-btn and btn (the latter used by Mosaic). So I approve from my end, but since I don't know if one of the other reviewers needs to run the tests under "How to test this PR", I'm not approving/triggering the merge. |
d6af260
to
5d2d90d
Compare
Reviewers, the SonarCloud failure is for the heavy amount of duplication between https://www.consumerfinance.gov/privacy/disclosure-consent/ and https://www.consumerfinance.gov/privacy/records-access/, which predates this PR. |
5d2d90d
to
fe6fdba
Compare
fe6fdba
to
22f7337
Compare
Fixed! |
FYI I force pushed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆒
Changes
u-small-text--subtle
from the DS.attach
tobehaviorAttach
.How to test this PR
a-btn--hide-icon
class is removed.Screenshots
Before:
After: