Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle a11y in video iframe #8636

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Handle a11y in video iframe #8636

merged 1 commit into from
Nov 13, 2024

Conversation

anselmbradford
Copy link
Member

Changes

  • Add placeholder title attribute to video iframe.
  • Remove aria-hidden and tabindex when the video has loaded.

How to test this PR

  1. Visit /about-us/blog/addressing-racial-inequities-consumer-finance-markets/ and load the page without JS enabled and see that there is a placeholder title attribute. Load the video normally and see that the title attribute value is replaced and the aria-hidden and tabindex values are removed.

@anselmbradford anselmbradford added this pull request to the merge queue Nov 13, 2024
Merged via the queue into main with commit 5c2041e Nov 13, 2024
17 checks passed
@anselmbradford anselmbradford deleted the ans_video_title branch November 13, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chosak chosak chosak approved these changes

@contolini contolini Awaiting requested review from contolini

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anselmbradford @chosak