Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to DS 3.4.14 #8654

Merged
merged 5 commits into from
Nov 22, 2024
Merged

Update to DS 3.4.14 #8654

merged 5 commits into from
Nov 22, 2024

Conversation

anselmbradford
Copy link
Member

@anselmbradford anselmbradford commented Nov 21, 2024

Update to DS 3.4.14, which does a few things:

  • Refactors the date picker to make it more consistently sized across web browsers, and nearer to the dimensions of a text input.
  • Adds a non-clickable pill pattern. This was in use in the FIG, but it could be clicked in the past, but do nothing. Prod currently only shows the text "Archived", which is a bug.
  • Moves some percentage width utilities to the DS, so that they can be removed in cfgov's CSS.

Removals

  • Removes unused percentage width utility classes.

Changes

  • Update to DS 3.4.14.
  • Fix issue where FIG tag class name needed to be updated.
  • Fix issue where no-js iregs search tag class name needed to be updated.

How to test this PR

  1. Visit http://localhost:8000/about-us/blog/ and see that the date pickers are 35px high, instead of 37px, which matches the height of the drop-down menus.

Copy link
Member

@contolini contolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@anselmbradford anselmbradford added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit 1ad5e99 Nov 22, 2024
16 checks passed
@anselmbradford anselmbradford deleted the ans_update_ds branch November 22, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants