Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable bypass of login/logout to allow customized user auth content #110

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

meissadia
Copy link
Contributor

@meissadia meissadia commented Jul 31, 2023

Closes #109

Changes

Skips rendering the built-in Login / Logout links when the expected user object is not provided. This allows consumers of the component to inject customized user auth content via the links prop.

Screenshots

No User object (Storybook -> Navbar -> No User)
Screenshot 2023-07-31 at 2 42 26 PM

"User logged in" via Navbar user object
Screenshot 2023-07-31 at 2 42 37 PM

Custom user auth content in SBL Frontend (buttons instead of links)
Screenshot 2023-07-31 at 2 44 08 PM

@netlify
Copy link

netlify bot commented Jul 31, 2023

Deploy Preview for cfpb-design-stories ready!

Name Link
🔨 Latest commit 329a7cf
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-stories/deploys/64c81f5eb33ed8000787773a
😎 Deploy Preview https://deploy-preview-110--cfpb-design-stories.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@meissadia meissadia enabled auto-merge (squash) July 31, 2023 20:46
Copy link
Member

@contolini contolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@meissadia meissadia merged commit 92e644c into main Aug 1, 2023
6 checks passed
@meissadia meissadia deleted the 109-page-header-login-flexibility branch August 1, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Component] PageHeader - More flexible User actions
2 participants