[Cypress/Docker] Streamline Docker Deployment Process #2304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as it is more widely used in the ecosystem. Removed yarn from Dockerfile and instead is using npm to simplify build and updated to newer ersion of Cypress and Node in the Dockerfile.
…install-cypress-dependencies.sh file. Updated Cypress conig to allow for videos to be made during run mode.
Michaeldremy
commented
Oct 21, 2024
There was a problem hiding this comment.
A file that used to install around 150 dependencies, is no longer needed since we are using Cypress/base image.
…packages are being remove due to critical CVEs - removed package do not prevent image from running.
Michaeldremy
commented
Oct 21, 2024
Comment on lines
+49
to
+53
| RUN find / -name "loader-utils" -type d -exec rm -rf {} + 2>/dev/null || true && \ | ||
| find / -name "flat" -type d -exec rm -rf {} + 2>/dev/null || true && \ | ||
| find / -name "underscore" -type d -exec rm -rf {} + 2>/dev/null || true && \ | ||
| npm cache clean --force && \ | ||
| chown -R hmda_cypress_user:hmda_cypress_user /hmda-frontend |
There was a problem hiding this comment.
Removing critical CVE packages. Not all of them can be removed otherwise image will not run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2054
Closes #1334
Re-wrote the Cypress Docker file to use base image from Cypress.
Updates to the Docker file include:
install-dependencies.shfile as it is no longer needednpmis being used to manage the install instead ofYarn