Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix alembic migration scripts and tests, add additional custom test #52

Merged
merged 1 commit into from
Nov 28, 2023
Merged

fix alembic migration scripts and tests, add additional custom test #52

merged 1 commit into from
Nov 28, 2023

Conversation

lchen-2101
Copy link
Collaborator

closes #50

@github-actions GitHub Actions
Copy link

Coverage report

The coverage rate went from 84.93% to 84.93% ⬇️
The branch rate is 85%.

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.

jcadam14
jcadam14 approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@jcadam14 jcadam14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my limited knowledge perspective, this looks good. Checked out changes and pulled feature branch and ran 'poetry run pytest' to verify output.

nargis-sultani
nargis-sultani approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@nargis-sultani nargis-sultani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lchen-2101 lchen-2101 merged commit fd0bb61 into main Nov 28, 2023
3 checks passed
@lchen-2101 lchen-2101 deleted the feature/50_fix_alembic_tests branch November 28, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nargis-sultani nargis-sultani nargis-sultani approved these changes

@jcadam14 jcadam14 jcadam14 approved these changes

@hkeeler hkeeler Awaiting requested review from hkeeler

@guffee23 guffee23 Awaiting requested review from guffee23

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expand Alembic testing
3 participants
@lchen-2101 @jcadam14 @nargis-sultani