Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Point of Contact] Phone Extension - 9 digit validation #997

Closed
shindigira opened this issue Oct 11, 2024 · 0 comments · Fixed by #1001
Closed

[Point of Contact] Phone Extension - 9 digit validation #997

shindigira opened this issue Oct 11, 2024 · 0 comments · Fixed by #1001
Assignees
@shindigira
Labels
enhancement New feature or request

Comments

@shindigira
Copy link
Contributor

See figma
@shindigira shindigira added the enhancement New feature or request label Oct 11, 2024
@shindigira shindigira self-assigned this Oct 11, 2024
@shindigira shindigira mentioned this issue Oct 15, 2024
Merged
meissadia pushed a commit that referenced this issue Oct 21, 2024
@shindigira @tanner-ricks @meissadia
[Point of Contact] Phone Extension - Limit to 9 digits, 0-9 in string (…
366c321 
…#1001)

closes #997

## Changes

- style(Point of Contact): Phone Extension always gets its own line
- content(Point of Contact): Change the helper and error text to match
the figma
- feat(Point of Contact): Phone Extension validation


## How to test this PR

1. Navigate to Point of Contact
2. Enter valid phone extension - ex. 00757
3. Enter invalid phone extension - ex ukhi778ih89h98h9h9h89h

## Screenshots
<img width="534" alt="Screenshot 2024-10-15 at 3 08 40 PM"
src="https://github.com/user-attachments/assets/7ed7bae8-9bc0-489f-9e63-a7748e8b9582">

---------

Co-authored-by: Tanner Ricks <182143365+tanner-ricks@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shindigira shindigira

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Point of Contact] Phone Extension - Limit to 9 digits, 0-9 in string cfpb/sbl-frontend
1 participant
@shindigira