-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Story] Indicate voluntary reporter status #1000
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tanner-ricks
Nice work! I think we're close. Just a couple of quick adjustments.
Provide filing details
- On dev pub this space is showing up as 60px. It should be 45px.
Dev Pub | Figma |
---|---|
- On dev pub this space is showing up as 45px. It should be 60px.
Dev Pub | Figma |
---|---|
- We decided to revert to the original approach to the privacy notice (shown here). At a later date we will push for a change but this will have to go through review from outside of our team. Can we update what we have on dev pub to reflect this?
Dev Pub | Figma |
---|---|
@billhimmelsbach
Will this issue be handled as a separate PR? Yes.
Sign and submit
- The spacing here should be 60px. It is showing up as 45px on Dev pub.
Dev Pub | Figma |
---|---|
- This may belong in the review for Sign and submit that I believe you're working on now...but this space should be 45px instead of 60px.
Dev Pub | Figma |
---|---|
Hi @natalia-fitzgerald @tanner-ricks! Thanks for the review @natalia-fitzgerald, the spacing for voluntary reporter status on the filing details and sign and submit page can be included, but I would exclude... The privacy notice changes aren't part of this PR
The state highlight box changes aren't part of this PR
The sign and submit alert box spacing stuff aren't part of this PR
So just a few minor spacing adjustments for the voluntary filing status, and then we're good to go. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tanner-ricks
I checked the following and these items look good and are approved.
Provide filing details
- Change the margin between the alert and the first section to 45px.
- Change the margin between the sections to 60px. Space between H2 sections should always be 60px (specifically between Indicate voluntary reporter status and Provide point of contact)
- Revert to previous approach to Privacy notice
Sign and submit
- Change the margin between the sections to 60px (specifically between Confirm your register information and Confirm voluntary reporter status)
@billhimmelsbach
|
Sounds good, I'll pick those up @natalia-fitzgerald |
Added frontend support for Voluntary Filing Status and renamed some page elements.
Changes
How to test this PR
Screenshots
Notes