Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[e2e] unavailableApis.spec - Refactor + add extended timeouts #1004

Merged
merged 3 commits into from
Oct 17, 2024
Merged

[e2e] unavailableApis.spec - Refactor + add extended timeouts #1004

merged 3 commits into from
Oct 17, 2024

Conversation

meissadia
Copy link
Collaborator

@meissadia meissadia commented Oct 16, 2024 •
edited
Loading

Part of #987

Changes

  • [e2e] Unavailable APIs
    • Refactored to make the tests easier to read and reduce code duplication (verifyApiBlockThenUnblock())
    • Added timeouts to enable test to consistently pass

How to test this PR

  1. Start sbl-frontend: yarn start
  2. Open Playwright: yarn playwright test --ui --workers 1
  3. Run test filing-app -> unavailableApis.spec.ts twice
  4. Confirm it passes consistently

Screenshots

Screenshot 2024-10-16 at 3 19 23 PM Screenshot 2024-10-16 at 3 22 14 PM

Notes

  • TODO (Future PR): Utilize e2e/utils/timeoutConstants.ts in more tests to reduce one-off timeout values

@meissadia meissadia marked this pull request as ready for review October 16, 2024 21:23
@meissadia meissadia mentioned this pull request Oct 16, 2024
Closed
5 tasks
@meissadia meissadia linked an issue Oct 16, 2024 that may be closed by this pull request
[e2e] Failing tests #987
Closed
5 tasks
@tanner-ricks tanner-ricks merged commit 4a12d6c into main Oct 17, 2024
4 checks passed
@tanner-ricks tanner-ricks deleted the 987-e2e-failing-tests branch October 17, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanner-ricks tanner-ricks tanner-ricks approved these changes

@billhimmelsbach billhimmelsbach Awaiting requested review from billhimmelsbach billhimmelsbach is a code owner

@shindigira shindigira Awaiting requested review from shindigira

@ojbravo ojbravo Awaiting requested review from ojbravo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[e2e] Failing tests
2 participants
@meissadia @tanner-ricks