[View Institution Profile] Language updates

[meissadia]

Closes #1013

Completed Changes

• Updated the fallback values for most fields to "Not applicable"
• Ensured Type of Financial Institution, Federal Taxpayer Identification Number (TIN) show as "Not provided" when missing
• Updated language for LEI Status from "Active/Inactive" to "Issued/Lapsed"
• Display alert for Type of Financial Institution, Federal Taxpayer Identification Number (TIN), or LEI Status when missing/lapsed.

How to test this PR

Language updates

    const testBlankValues = {
      lei: 'FI_LEI',
      name: 'FI_INSTITUTION_NAME',
      hq_address_street_1: 'HQ_ADDRESS_STREET_1',
      hq_address_city: 'HQ_ADDRESS_CITY',
      hq_address_state: 'HQ_ADDRESS_STATE',
      hq_address_state_code: 'HQ_ADDRESS_STATE_CODE',
      hq_address_zip: 'HQ_ADDRESS_ZIP',
    };

1. [ViewInstitutionProfile > index.tsx] Replace the data param highlighted in the screenshot below with the following.
   

2. Visit the Institution profile page

   • ex. http://localhost:8899/institution/123456789TESTBANK123

3. Confirm fields display the correct fallback value (blank or "Not applicable").

Screenshots

Language updates

• Fields marked as Always populated in the reference table are populated with their fieldname (i.e FI_INSTITUTION_NAME)
• Field that were previously "blank" are displayed as "Not populated" (TIN, Types of Financial Institution).
• Others are populated with the appropriate fallback value.

[tanner-ricks]

Looks fine from my end. Don't know if Natalia needs to check this out or not though.

[meissadia]

@natalia-fitzgerald I've updated this PR to switch blank fields to display as "Not provided". The screenshot above reflects these changes.

[meissadia]

@natalia-fitzgerald Added the warning alert when missing TIN or Type of FI. Screenshot above has been updated.

I notice the spacing between ! icon and the text in my implementation compared to your reference image differs (less in my implementation). Wondering if this is a one-off issue we should address in the SBL Frontend or if this is an issue with the DSR's Alert (field-level) component.

[meissadia]

@natalia-fitzgerald Also updated to include the alert for Lapsed LEIs.

[natalia-fitzgerald]

@meissadia
This is looking good. Just one text adjustment and we should be good to go on the immediate task.

For "Type of financial institution" can you update the text to:
You must provide your type of financial institution to file. Visit update your financial institution profile to provide this information.

---

I also noticed the spacing/alignment issue between ! icon and the text. I seem to recall us flagging this as a problem with the DSR's field level alert.

Here's how the DSR's field level alert looks:

• Space between icon and text is tight and text appears to sit on the baseline of the icon (rather than centered)

This might be the PR where we explored fixing this (almost a year ago):
cfpb/design-system-react#278

[meissadia]

@natalia-fitzgerald Alert message for Type of financial institution has been updated. Screenshot updated.

Based on the referenced PR about Alert spacing, sounds like a "later" item, so I'll leave it alone for now.

[natalia-fitzgerald]

@meissadia
This looks good.

My only remaining question is whether email domain should be "not available" as shown in the screenshot. My understanding is that we would always have email domain unless the entire system is down in some way. Is this correct? If so, I don't think we would ever show "Not available" for that field.

[billhimmelsbach]

Looks good @meissadia!