Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e] Make tests runnable against dev deployment #1029

Merged
merged 6 commits into from
Oct 29, 2024
Merged

Conversation

tanner-ricks
Copy link
Contributor

@tanner-ricks tanner-ricks commented Oct 25, 2024

Made tests configurable through environment variables in preparation for running against the dev deployment

Changes

  • Created environment variables for test
  • Added Constants file to pull in the environment variables for test
  • Updated hard coded locations to use the values in the Constants file instead
  • Updated playwright config to pull in the base url as an environment variable

How to test this PR

  1. Read the Notes
  2. Pull the branch
  3. Relaunch the stack if necessary
  4. Run the e2e tests and verify that they all still pass
  5. Play with the envars if you wish and see that the behavior changes as the envars do

Notest

  • There appears to be a test failure in InstitutionProfile.spec.ts that is coming from Design System React.
    • If you encounter this, you can ignore it.

@tanner-ricks tanner-ricks changed the title [e2e] Make tests runnable against dev deployment DRAFT: [e2e] Make tests runnable against dev deployment Oct 25, 2024
@tanner-ricks tanner-ricks changed the title DRAFT: [e2e] Make tests runnable against dev deployment [e2e] Make tests runnable against dev deployment Oct 29, 2024
@tanner-ricks tanner-ricks marked this pull request as ready for review October 29, 2024 15:29
Copy link
Collaborator

@meissadia meissadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

I still get failures but they have nothing to do with this configuration since all the filing-app tests passed.

Screenshot 2024-10-29 at 10 37 53 AM

@tanner-ricks tanner-ricks merged commit ce3fc42 into main Oct 29, 2024
4 checks passed
@tanner-ricks tanner-ricks deleted the 1015-dev-e2e-tests branch October 29, 2024 18:44
@tanner-ricks tanner-ricks linked an issue Oct 29, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[e2e] Make tests runnable against dev deployment
2 participants