[Institution profile] Page-level error for API issues #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meissadia
changed the title
|
@meissadia |
…instead of 500 page
meissadia
force-pushed
the
1030-institution_profile-page_level_error
branch
from
b83c959
to
76edbea
Compare
meissadia
requested review from
billhimmelsbach and
tanner-ricks
as code owners
|
@natalia-fitzgerald Implementation updated to match you mockup. Screenshot updated above. |
|
@meissadia |
natalia-fitzgerald
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
@meissadia
The only small change I have is to add the underline to the link. Looks good!
|
Updated to address missing underline for email link. Screenshot updated to show latest state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1030
Changes
500pageHow to test this PR
localhost:8881/v1/institutions/123456789TESTBANK123Screenshots