Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Page] [Provide Filing Details] Rename Files and Update Tests #1032

Merged
merged 7 commits into from
Oct 31, 2024

Conversation

tanner-ricks
Copy link
Contributor

@tanner-ricks tanner-ricks commented Oct 29, 2024

Moving/Renaming Files and updating Tests

Changes

  • Found appropriate instances of "point of contact" and renamed them to "filing details"
  • Moved files from point of contact directories to filing details directories
  • Updated test fixture to click a voluntary reporter status

How to test this PR

  1. Pull the branch in sbl-frontend
  2. Make sure that the following additional projects are up to date
    • regtech-cleanup-api
    • regtech-mail-api
    • regtech-user-fi-management
    • sbl-filing-api
    • sbl-project
  3. Restart the stack as necessary
  4. Navigate from/to filing details and verify that things are navigating correctly
  5. Run the e2e tests and verify that they pass with the exception of the those mentioned in the notes

@tanner-ricks tanner-ricks changed the title Draft: [Page] [Provide Filing Details] Rename Files and Update Tests [Page] [Provide Filing Details] Rename Files and Update Tests Oct 29, 2024
@tanner-ricks tanner-ricks marked this pull request as ready for review October 29, 2024 18:21
@tanner-ricks tanner-ricks linked an issue Oct 29, 2024 that may be closed by this pull request
@meissadia
Copy link
Collaborator

@tanner-ricks Seeing some failures (outside of those I normally struggle against)
Screenshot 2024-10-30 at 2 40 49 PM
Screenshot 2024-10-30 at 2 40 58 PM

@tanner-ricks
Copy link
Contributor Author

tanner-ricks commented Oct 30, 2024

@tanner-ricks Seeing some failures (outside of those I normally struggle against) Screenshot 2024-10-30 at 2 40 49 PM Screenshot 2024-10-30 at 2 40 58 PM

@meissadia Make sure that you have all of the other service repos up to date. There were some changes in the filing api that I think you need, I'll update the test steps to reflect this as well. Also, probably want to pull this repo again since I have integrated your test changes as well

Copy link
Collaborator

@meissadia meissadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the added guidance. I had updated some, but not all, of the dependent repos. Once I synched everything the tests started passing.

👍🏾

@tanner-ricks tanner-ricks merged commit 535bda6 into main Oct 31, 2024
4 checks passed
@tanner-ricks tanner-ricks deleted the 1018-details-refactor-and-tests branch October 31, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Page] [Provide Filing Details] Rename Files and Update Tests
2 participants