Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Display Docker image tag in app Footer to help identify deployed changes #1045

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Display Docker image tag in app Footer to help identify deployed changes #1045

wants to merge 1 commit into from

Conversation

meissadia
Copy link
Collaborator

Close #1044

Note: Generation of the DOCKER_TAG build-arg is built into the SBL CLI

Changes

  • Displays the provided "version" tag at the bottom of each page

How to test this PR

  1. Include the desired display tag in your Docker build command: --build-arg DOCKER_TAG=1044-show-tag
  2. Verify it is displayed at the bottom of the page

Screenshots

Screenshot 2024-11-04 at 1 37 32 PM

tanner-ricks
tanner-ricks approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@tanner-ricks tanner-ricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Assuming we don't need UI approval, you're good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanner-ricks tanner-ricks tanner-ricks approved these changes

@billhimmelsbach billhimmelsbach Awaiting requested review from billhimmelsbach billhimmelsbach is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Easily identify deployed changes
2 participants
@meissadia @tanner-ricks