Nginx CSP Update #742
Merged
Nginx CSP Update #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ojbravo
requested review from
billhimmelsbach,
meissadia and
shindigira
as code owners
billhimmelsbach
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Heyo! This works super great Omar! This set up will fail currently though do to the hardened nginx image, but when you update with main to get some of the security changes we merged last night, it'll work great!
This will be a huge time saver if we end up needing this for approval, and I really appreciate your work making this ready to go! Thanks @ojbravo! 👍
|
Looks great @ojbravo! We really appreciate your work on this! |
|
|
|
|
|
|
|
|
|
SEND IT! |
|
|
billhimmelsbach
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
🚀 Thanks for your awesome work, and welcome to the team @ojbravo! 🚀
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added GA code to index.html. Replaced 'unsafe-inline' in nginx.conf with nonce and white-listed https://dap.digitalgov.gov